Public Queries #119

hobbescodes · 2025-05-01T03:24:30Z

Description

Task link: https://linear.app/omnidev/issue/OMNI-340/unauth-users-should-be-able-to-see-projects

This PR refactors limitations on rendering for all pages that should be available to be viewed by unauthorized users. The biggest change this PR implements is removing the need for a valid accessToken to perform queries.

Important

Must be tested in combination with omnidotdev/backfeed-api#47

In Addition, other refactors available in this PR can be found here: #140

Test Steps

Verify that logic is sound
Validate that all routes have appropriate access control and render as expected
Validate that state management for CTAs, form elements, etc are appropriate for unauthorized users
Validate that the query option changes are appropriate and work as expected based on the linked PR description

…ation` accessor

This reverts commit ad0e24f.

…g and punctuation

…v regardless of auth

…route when not authenticated

hobbescodes · 2025-05-07T17:27:02Z

src/app/organizations/[organizationSlug]/(manage)/layout.tsx

We could lock these routes down still if we would like. Happy to adjust!

… projects to view

Twonarly1 · 2025-05-15T11:19:05Z

src/components/organization/OrganizationManagement/OrganizationManagement.tsx

@@ -11,7 +11,7 @@ import { app } from "lib/config";
 import { useOrganizationMembership } from "lib/hooks";

 import type { ButtonProps } from "@omnidev/sigil";
-import type { Organization } from "generated/graphql";
+import { type Organization, useOrganizationQuery } from "generated/graphql";


Suggested change

import { type Organization, useOrganizationQuery } from "generated/graphql";

import type { Organization } from "generated/graphql";

Twonarly1 · 2025-05-15T11:19:46Z

src/components/organization/OrganizationManagement/OrganizationManagement.tsx

@@ -11,7 +11,7 @@ import { app } from "lib/config";
 import { useOrganizationMembership } from "lib/hooks";


Suggested change

import { useOrganizationMembership } from "lib/hooks";

import { useOrganizationQuery } from "generated/graphql";

import { useOrganizationMembership } from "lib/hooks";

…not signed in

* refactor: update infinite post structures to use query options API * refactor: update feedback by ID structures to use query options API * refactor: update project structures to use query options API

hobbescodes and others added 30 commits April 28, 2025 19:52

refactor(recent-feedback): stabilize relative timestamps

91749c3

refactor(page): make description optional, update copy

474663d

chore(copy): update org page copy

d1ca0a4

chore(profile): remove close account CTA

a0efad7

chore(profile): Edit -> Manage

914b955

fix: fix email addresses (WIP)

1098292

chore(env): extract from/to email addresses to env vars

30fc676

chore: remove unused imports

2f9be6f

chore: rename 'identityUrl' -> 'identityProviderUrl'

6dfbc88

refactor(app-config): nest organization-related strings into `organiz…

5db3003

…ation` accessor

chore(app-config): add JSDoc

98143c9

feature(recent-feedback): add project name

1214996

feature(recent-feedback): add link, change feedback description to title

55ebf08

chore(app-config): normalize copy (remove punctuation)

b14508d

style(recent-feedback): add information to card

c7c99d7

fix(recent-feedback): use custom link component

0b38884

docs(link): update props docs

e31976f

style(recent-feedback): set last item bottom padding

fbd6233

refactor(feedback-section): Flex -> Stack

ed5f541

style(recent-feedback): set last item bottom margin

fca46a0

chore(comments): remove min length

985f867

refactor(recent-feedback): update responsive design

0a2186b

refactor(dashboard): include today's feedback in feedback overview

825b92d

refactor: remove UTC conversions

ad0e24f

Revert "refactor: remove UTC conversions"

aa73d82

This reverts commit ad0e24f.

chore: remove duration plugin

e0f4c4b

fix: update manage profile href for both dev and prod environments

ea8a7fd

refactor: move view all organizations outside of pinned orgs scope

a4af542

Refresh Token Rotation (#118)

62e5a1f

fix(copy): set singular if value is 1, plural otherwise, update casin…

0e99cc7

…g and punctuation

hobbescodes added 6 commits May 7, 2025 10:20

refactor(feedback): adjust types for component props

fc76f1e

refactor: disable voting buttons if user is not signed in

7cdb2bf

refactor(dashboard): adjust styles to prevent box shadow clipping

62ee398

refactor(header): add organizations link, update sidebar to enable na…

369d00d

…v regardless of auth

refactor: add prefetched queries based on session conditionally

196203f

refactor(middleware): redirect user if trying to access confirmation …

8690791

…route when not authenticated

hobbescodes commented May 7, 2025

View reviewed changes

hobbescodes added 11 commits May 7, 2025 13:20

refactor(graphql): remove instances of create user mutation

a8af0be

fix(recent-feedback): adjust container width

a12da41

Merge branch 'master' into feature/public-queries

10d7695

Merge branch 'master' into feature/public-queries

92f75cd

Merge branch 'master' into feature/public-queries

51fc22d

Merge branch 'master' into feature/public-queries

e6b9a7f

Merge branch 'master' into feature/public-queries

2a0925f

Merge branch 'master' into feature/public-queries

993f3f9

Merge branch 'master' into feature/public-queries

d60f7f3

refactor: make adjustments to disabled states and user access

318135d

refactor(organization): disable view all projects CTA if there are no…

f3d1c2e

… projects to view

hobbescodes marked this pull request as ready for review May 15, 2025 02:49

refactor(util): allow queries to refetch on window focus

8f12171

Twonarly1 reviewed May 15, 2025

View reviewed changes

hobbescodes added 8 commits May 15, 2025 08:35

chore(org-management): update import sorting

ff93c0c

chore(org-management): update import sorting

6e84823

refactor(voting-buttons): update opacity and tooltips when a user is …

24aabf0

…not signed in

Merge branch 'master' into feature/public-queries

28e59e0

Use queryOptions API (#140)

371693c

* refactor: update infinite post structures to use query options API * refactor: update feedback by ID structures to use query options API * refactor: update project structures to use query options API

Merge branch 'master' into feature/public-queries

cb4b361

Merge branch 'master' into feature/public-queries

50be431

Merge branch 'master' into feature/public-queries

0dc8ae1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Public Queries #119

Public Queries #119

Uh oh!

hobbescodes commented May 1, 2025 •

edited

Loading

Uh oh!

hobbescodes May 7, 2025

Uh oh!

Twonarly1 May 15, 2025

Uh oh!

Twonarly1 May 15, 2025

Uh oh!

Uh oh!

	import { type Organization, useOrganizationQuery } from "generated/graphql";
	import type { Organization } from "generated/graphql";

		@@ -11,7 +11,7 @@ import { app } from "lib/config";
		import { useOrganizationMembership } from "lib/hooks";

	import { useOrganizationMembership } from "lib/hooks";
	import { useOrganizationQuery } from "generated/graphql";
	import { useOrganizationMembership } from "lib/hooks";

Public Queries #119

Are you sure you want to change the base?

Public Queries #119

Uh oh!

Conversation

hobbescodes commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Task link: https://linear.app/omnidev/issue/OMNI-340/unauth-users-should-be-able-to-see-projects

Test Steps

Uh oh!

hobbescodes May 7, 2025

Choose a reason for hiding this comment

Uh oh!

Twonarly1 May 15, 2025

Choose a reason for hiding this comment

Uh oh!

Twonarly1 May 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hobbescodes commented May 1, 2025 •

edited

Loading